[ 
https://issues.apache.org/jira/browse/PROTON-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995746#comment-16995746
 ] 

Andrew Stitcher commented on PROTON-2162:
-----------------------------------------

I would tend to say that this is not actually a regression in that both times 
you get a close frame jsut with a slightly different message,

However I think this reproducer actually covers a bunch of different bugs: 
(which we should break apart)
* The C++ binding doesn't correctly cope with aborted messages
* The C++ binding doesn't correctly deal with malformed messages
* Proton-c itself may also be handling received aborted message incorrectly.

As best I can tell with a limited look at the code, and runnign under the 
debugger a bit, it seems that there are three separate problems here.

> [c] Regression with aborted transfers: connection closes with framing error
> ---------------------------------------------------------------------------
>
>                 Key: PROTON-2162
>                 URL: https://issues.apache.org/jira/browse/PROTON-2162
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: proton-c-0.29.0
>         Environment: Fedora 29, debug build
>            Reporter: Charles E. Rolke
>            Priority: Major
>
> Using normal example code:
>  * run build/cpp/examples/direct_recv
>  * run build/c/examples/send-abort
> Tested against 0.27.1, 0.28.0, 0.29.0, and 0.30.1-rc1
> In all cases direct_recv exits with a 'receiver read failure' upon receiving 
> the first aborted transfer.
> In older versions (before 0.30.x) send_abort receives a close with error:
> {noformat}
>  0 -> @close(24) [error=@error(29) [condition=:"proton:io", 
> description="Connection reset by peer - on write to :5672 (connection 
> aborted)"]]
> {noformat}
> In the 0.30.1-rc1 version the send_abort receives a close with error:
> {noformat}
>  AMQP:FRAME:0 -> @close(24) [error=@error(29) 
> [condition=:"amqp:connection:framing-error", description="connection 
> aborted"]]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to