[ 
https://issues.apache.org/jira/browse/PROTON-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995855#comment-16995855
 ] 

Charles E. Rolke commented on PROTON-2162:
------------------------------------------

After further study this doesn't look like a functional regression.

The error message is slightly different, yes, but it changed from a _proton:io_ 
error into a _amqp:connection:framing-error_. That's a pretty big logical leap 
for describing when a client disconnects. Grepping the qpid-dispatch self test: 
the open performative is logged 4,800 times and the closed performative with 
framing-error is logged 713 times. That's a lot of noise and is really 
unhelpful in describing what's happening.

I switched my testing to  use the python client and put in a proper on_aborted 
callback handler. With that connections run for thousands of aborted messages 
no problem.

> [c] Regression with aborted transfers: connection closes with framing error
> ---------------------------------------------------------------------------
>
>                 Key: PROTON-2162
>                 URL: https://issues.apache.org/jira/browse/PROTON-2162
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: proton-c-0.29.0
>         Environment: Fedora 29, debug build
>            Reporter: Charles E. Rolke
>            Priority: Major
>
> Using normal example code:
>  * run build/cpp/examples/direct_recv
>  * run build/c/examples/send-abort
> Tested against 0.27.1, 0.28.0, 0.29.0, and 0.30.1-rc1
> In all cases direct_recv exits with a 'receiver read failure' upon receiving 
> the first aborted transfer.
> In older versions (before 0.30.x) send_abort receives a close with error:
> {noformat}
>  0 -> @close(24) [error=@error(29) [condition=:"proton:io", 
> description="Connection reset by peer - on write to :5672 (connection 
> aborted)"]]
> {noformat}
> In the 0.30.1-rc1 version the send_abort receives a close with error:
> {noformat}
>  AMQP:FRAME:0 -> @close(24) [error=@error(29) 
> [condition=:"amqp:connection:framing-error", description="connection 
> aborted"]]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to