kgiusti commented on a change in pull request #663: DISPATCH-1541: Sets the
presettled flag on large streaming discarded …
URL: https://github.com/apache/qpid-dispatch/pull/663#discussion_r367075860
##########
File path: src/router_core/delivery.c
##########
@@ -124,6 +124,11 @@ bool qdr_delivery_is_aborted(const qdr_delivery_t
*delivery)
return qd_message_aborted(delivery->msg);
}
+void qdr_delivery_set_presettled(qdr_delivery_t *delivery)
+{
+ if (! delivery->presettled)
+ delivery->presettled = true;
Review comment:
Why the conditional check - it's not necessary. Simply set
delivery->presettled.
Or change the check to be sure delivery != 0 instead.... up to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
