[ 
https://issues.apache.org/jira/browse/DISPATCH-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034508#comment-17034508
 ] 

ASF GitHub Bot commented on DISPATCH-1518:
------------------------------------------

kgiusti commented on pull request #676: DISPATCH-1518: Added ability to turn on 
protocol frame trace logging …
URL: https://github.com/apache/qpid-dispatch/pull/676#discussion_r377662447
 
 

 ##########
 File path: src/router_core/router_core_private.h
 ##########
 @@ -681,6 +684,7 @@ struct qdr_connection_t {
     bool                        closed; // This bit is used in the case where 
a client is trying to force close this connection.
     uint32_t                    conn_uptime; // Timestamp which can be used to 
calculate the number of seconds this connection has been up and running.
     uint32_t                    last_delivery_time; // Timestamp which can be 
used to calculate the number of seconds since the last delivery arrived on this 
connection.
+    bool                        enable_protocol_trace; // Has trace level 
logging been turned on for this connecvtion.
 
 Review comment:
   "connecvtion"?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add ability to turn on router trace logging for a specific connection 
> ----------------------------------------------------------------------
>
>                 Key: DISPATCH-1518
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1518
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 1.9.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>             Fix For: 1.11.0
>
>
> It would be nice to be able to turn on tracing per connection, e.g. something 
> like `qdmanage update --type=connection id=897644 tracing=true`
> That way you could benefit from protocol level tracing on connections of 
> interest as and when needed. Perhaps also there could be some way of 
> specifying a policy for connection tracing, e.g. all connections whose 
> container id is 'foo' or who are connecting from 192.666.555.444 or similar.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to