[ 
https://issues.apache.org/jira/browse/DISPATCH-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034583#comment-17034583
 ] 

ASF GitHub Bot commented on DISPATCH-1518:
------------------------------------------

ganeshmurthy commented on pull request #676: DISPATCH-1518: Added ability to 
turn on protocol frame trace logging …
URL: https://github.com/apache/qpid-dispatch/pull/676#discussion_r377746563
 
 

 ##########
 File path: python/qpid_dispatch/management/client.py
 ##########
 @@ -76,6 +76,16 @@ def delete(self):
 class Node(object):
     """Client proxy for an AMQP management node"""
 
+    def clean_attrs(self, attrs):
+        BOOL_VALUES = {"yes": 1, "true": 1, "on": 1, "no": 0, "false": 0,
 
 Review comment:
   This is tough question. I think 'Yes' should be invalid, so should 'YES' or 
'YEs' or 'NO' or 'No'
   Please let me know what your thoughts on that are.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add ability to turn on router trace logging for a specific connection 
> ----------------------------------------------------------------------
>
>                 Key: DISPATCH-1518
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1518
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 1.9.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>             Fix For: 1.11.0
>
>
> It would be nice to be able to turn on tracing per connection, e.g. something 
> like `qdmanage update --type=connection id=897644 tracing=true`
> That way you could benefit from protocol level tracing on connections of 
> interest as and when needed. Perhaps also there could be some way of 
> specifying a policy for connection tracing, e.g. all connections whose 
> container id is 'foo' or who are connecting from 192.666.555.444 or similar.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to