[
https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039594#comment-17039594
]
ASF GitHub Bot commented on DISPATCH-1568:
------------------------------------------
nicob87 commented on pull request #684: WIP: (Work In Progress) DISPATCH-1568:
using doctest
URL: https://github.com/apache/qpid-dispatch/pull/684#discussion_r381019059
##########
File path: src/router_core/terminus.c
##########
@@ -75,25 +76,47 @@ void qdr_terminus_free(qdr_terminus_t *term)
free_qdr_terminus_t(term);
}
+#ifdef TESTING
+__attribute__((weak))
Review comment:
no need to make it weak since this goes to a shared library.
__attribute__((noinline)) probably is a good idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> add c-unittest support
> ----------------------
>
> Key: DISPATCH-1568
> URL: https://issues.apache.org/jira/browse/DISPATCH-1568
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Reporter: Nicolas
> Priority: Major
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Right now we are not using any framework for easily write c unit-test when
> developing (or later).
> The idea is to research available libraries, pick one and try to include in
> our workflow.
> preliminary candidates:
> [https://github.com/google/googletest]
> https://github.com/catchorg/Catch2
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
