[
https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163387#comment-17163387
]
ASF GitHub Bot commented on DISPATCH-1568:
------------------------------------------
jiridanek commented on pull request #684:
URL: https://github.com/apache/qpid-dispatch/pull/684#issuecomment-662915480
I've changed it some more, see my commits
* DISPATCH-1568 Update RuntimeChecks to work with C++ code
Since we are not mocking, the tests can run under any kind of build,
including ASan builds. That requires passing the asan compile args to C++
compiler.
* DISPATCH-1568 c-unittests: replace #define with C++ const, use SUBCASEs
more
C++ is nice in that e.g. `const int size=5; int array[size]` is allowed. No
need for #defines.
* DISPATCH-1568 Add terminus_private.h to make the `static` method testable
@kgiusti had some nice things to say about the _private.h convention, and I
think it is a good match in this situation as well. Correct me if I am wrong.
* DISPATCH-1568 Remove qpid-dispatch-testing library (mocking proposal)
Since we aren't mocking (yet), we don't need to build a special version of
the library for the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> add c-unittest support
> ----------------------
>
> Key: DISPATCH-1568
> URL: https://issues.apache.org/jira/browse/DISPATCH-1568
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Reporter: Nicolas
> Priority: Major
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Right now we are not using any framework for easily write c unit-test when
> developing (or later).
> The idea is to research available libraries, pick one and try to include in
> our workflow.
> preliminary candidates:
> [https://github.com/google/googletest]
> [https://github.com/catchorg/Catch2]
> [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Clients
> using this one (old catch2)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
