jiridanek commented on a change in pull request #702: NO-JIRA Improve printing
of results in travis.yml
URL: https://github.com/apache/qpid-dispatch/pull/702#discussion_r391977081
##########
File path: .travis.yml
##########
@@ -36,12 +36,14 @@ matrix:
cache:
directories:
- $HOME/.m2/repository
- before_cache:
- - rm -rf $HOME/.m2/repository/org/apache/qpid/*
+ before_cache:
+ - rm -rf $HOME/.m2/repository/org/apache/qpid/*
install: []
before_script: []
script:
- mvn apache-rat:check
+ after_failure:
+ - cat target/rat.txt
Review comment:
If it does not exist, a nonzero return value from the last after_failure
command does not really change anything. To some degree, missing target/rat.txt
can be considered an additional failure, because of the expected way the rat CI
job is supposed to fail.
I can add the check, it would make the job then future-proof against adding
additional commands to after_failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
