[
https://issues.apache.org/jira/browse/PROTON-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071072#comment-17071072
]
ASF GitHub Bot commented on PROTON-2158:
----------------------------------------
conniey commented on issue #37: PROTON-2158 Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-606073224
> Can I also ask why you did the override on the parent managed jar plugin
version?
No reason to use this version. I removed it.
> I want to look into some odd behaviour around other manifest entries that
get added after the change
I'm not sure why they didn't show up when built from master, but the entries
appear in previous versions of proton-j. :( I only know enough about
maven-bundle-plugin to execute `bundle:bundle`. Looking at the manifest
instructions, it looks like we did expect all those `Export-Package` entries.
https://github.com/apache/qpid-proton-j/blob/master/pom.xml#L100
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add 'Automatic-Module-Name' to MANIFEST.MF to support Java 9+ modules
> ---------------------------------------------------------------------
>
> Key: PROTON-2158
> URL: https://issues.apache.org/jira/browse/PROTON-2158
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: proton-j-0.33.2
> Reporter: Connie Yau
> Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Our team ships libraries that work on JDK 9+ with their module system. It
> would be nice to have an automatic-module-name in the JAR.
> [http://branchandbound.net/blog/java/2017/12/automatic-module-name/]
> Note: This is not about modularising qpid-proton-j; this is just adding an
> automatic module name. I think modularising the library is another task in
> itself.
> In our project, it shows warnings when building for JDK 11.
> {{[WARNING] * Required filename-based automodules detected:
> [proton-j-0.33.2.jar]. Please don't publish this project to a public artifact
> repository! *}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
