[
https://issues.apache.org/jira/browse/PROTON-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071841#comment-17071841
]
ASF GitHub Bot commented on PROTON-2158:
----------------------------------------
gemmellr commented on issue #37: PROTON-2158 Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-606663536
I've pushed your changes in
https://github.com/apache/qpid-proton-j/commit/20c9943086678159d3776ebab03516eb11ed0f4a
and added a further change in
https://github.com/apache/qpid-proton-j/commit/02998b382967b997ac86a6b1ea2d507bfd9a862f
to address the other entries being added.
(The Apache parent pom has dependencyManagement with configuration for the
maven jar plugin, which isnt picked up by the bundle plugin when used due to
'bundle' packaging type... unless also adding an explicit jar plugin config as
your change did, even though the bundle plugin is still used instead of the jar
plugin. Odd.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add 'Automatic-Module-Name' to MANIFEST.MF to support Java 9+ modules
> ---------------------------------------------------------------------
>
> Key: PROTON-2158
> URL: https://issues.apache.org/jira/browse/PROTON-2158
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: proton-j-0.33.2
> Reporter: Connie Yau
> Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Our team ships libraries that work on JDK 9+ with their module system. It
> would be nice to have an automatic-module-name in the JAR.
> [http://branchandbound.net/blog/java/2017/12/automatic-module-name/]
> Note: This is not about modularising qpid-proton-j; this is just adding an
> automatic module name. I think modularising the library is another task in
> itself.
> In our project, it shows warnings when building for JDK 11.
> {{[WARNING] * Required filename-based automodules detected:
> [proton-j-0.33.2.jar]. Please don't publish this project to a public artifact
> repository! *}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
