gemmellr commented on issue #37: PROTON-2158 Adding automatic module name entry. URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-606663536 I've pushed your changes in https://github.com/apache/qpid-proton-j/commit/20c9943086678159d3776ebab03516eb11ed0f4a and added a further change in https://github.com/apache/qpid-proton-j/commit/02998b382967b997ac86a6b1ea2d507bfd9a862f to address the other entries being added. (The Apache parent pom has dependencyManagement with configuration for the maven jar plugin, which isnt picked up by the bundle plugin when used due to 'bundle' packaging type... unless also adding an explicit jar plugin config as your change did, even though the bundle plugin is still used instead of the jar plugin. Odd.)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
