RoddieKieley commented on a change in pull request #239: PROTON-2190 Fix 
url_test.go on macOS
URL: https://github.com/apache/qpid-proton/pull/239#discussion_r409776131
 
 

 ##########
 File path: go/pkg/amqp/url_test.go
 ##########
 @@ -32,13 +35,6 @@ func ExampleParseURL() {
                "amqps://host",
                "/path",
                "",
-               ":1234",
-                // Taken out because the go 1.4 URL parser isn't the same as 
later
 
 Review comment:
   Go 1.4 or the latest Go 1.14 in this case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to