ted-ross commented on pull request #731: URL: https://github.com/apache/qpid-dispatch/pull/731#issuecomment-624661094
> One suggestion: The logic that adds/removes the link_ref to the qdr_address_t (QDR_LINK_CLASS_ADDRESS) by checking the initial_credit_received value is repeated across a couple of files here. > > I'd suggest moving that logic into its own two functions and calling them instead. Thanks. I'll look into making this change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
