ChugR commented on a change in pull request #748:
URL: https://github.com/apache/qpid-dispatch/pull/748#discussion_r431247067
##########
File path: CMakeLists.txt
##########
@@ -61,8 +61,6 @@ message(STATUS "Found Proton: ${Proton_LIBRARIES} (found
version \"${Proton_VERS
## Optional dependencies
find_package(LibWebSockets)
Review comment:
What if I want to build without LibWebSockets? There's no option any
more.
A good plan is to keep the option USE_LIBWEBSOCKETS and default it true
before you try to find the package. Only look for the package if the option is
true. Then if you find libwebsockets and the version is ok go ahead and use it.
##########
File path: CMakeLists.txt
##########
@@ -61,8 +61,6 @@ message(STATUS "Found Proton: ${Proton_LIBRARIES} (found
version \"${Proton_VERS
## Optional dependencies
find_package(LibWebSockets)
Review comment:
Take a look at console/CMakeLists.txt and how it handles CONSOLE_INSTALL
for a good pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
