gemmellr commented on pull request #263: URL: https://github.com/apache/qpid-proton/pull/263#issuecomment-658125577
@kpvdr Yes, the comment applies to codec tests in general. It wouldn't surprise me if other existing test dont do it, though for me that definitely isnt reason not to do it here. More the reverse; we might not have hit some previous issues if they did, and array encodings are more complicated than most and so more likely to be broken. As they currently were, and could easily be again in other ways. If the arrays are still using the non-list0 encoding for empty lists thats fine, I didn't look at the code enough to see what it actually did, I just think having the test of whatever its expected to be doing makes sense. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
