gemmellr commented on pull request #779:
URL: https://github.com/apache/qpid-dispatch/pull/779#issuecomment-662399648
Is the javascript action doing anything? It doesnt appear to in the log, and
its repo makes it seem more like a base action others would build their own
Actions upon than anything else.
I think it would be nice to give the jobs+steps names, rather than just
having the commands show up in the overview etc. I prepared a tweaked version
that drops the javascript action and adds names etc:
```
on: [push, pull_request]
jobs:
test:
name: Tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Install Console
run: cd console/react && npm install
- name: Run Tests
run: cd console/react && npm run test
eslint:
name: ESLint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Install Console
run: cd console/react && npm install
- name: Install Typescript
run: cd console/react && npm install typescript
- name: Run ESLint
run: cd console/react && npx eslint --max-warnings 0 .
```
Either version could perhaps be expanded to run the tests on different
NodeJS versions, e.g see:
https://docs.github.com/en/actions/language-and-framework-guides/using-nodejs-with-github-actions.
Note that if doing that, I would also set the strategy config for "fail-fast:
false" otherwise it aborts the entire matrix by default if any of them fail.
P.S. maybe squash commits like these before raising the PR ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
