jiridanek edited a comment on pull request #294: URL: https://github.com/apache/qpid-dispatch/pull/294#issuecomment-663054639
@gemmellr It already does what it is supposed to do, so I thought it is ready to be merged. The improvement is there, macOS travis job is allowed to fail, and the behavior on invalid protocol name is not any worse than it was before. I did not close the Jira because I was planning to revisit the issue regarding my comments, either myself when there is the c_unittests pr merged, which should be soon now, or see if @fgiorgetti maybe fixes it in the meantime. edit: if what I've done is questionable, which I acknowledge it probably is, I'll learn for the future. Anyways, i wouldn't've spotted the macOS failure until I rebased and merged the PR, because the PR is older than the macOS job in Travis. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
