gemmellr commented on pull request #294: URL: https://github.com/apache/qpid-dispatch/pull/294#issuecomment-663083285
Ok. If there are comments like 'x is wrong', 'should also do x', and 'gets a random port instead of error when doing <foo>' (I was unclear if that was also true previously or not, but it seems like part of the same issue ither way) I'd personally leave it unmerged until addressed one way or anotehr by someone or other...or perhaps resolve the original JIRA and raise another to consider as seperate issues later if not important. Fair re: OSX failure and the job not existing (rebases can always be pushed to forks for testing first though hehe) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
