[
https://issues.apache.org/jira/browse/PROTON-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164559#comment-17164559
]
Andrew Stitcher commented on PROTON-2253:
-----------------------------------------
{quote}Right, but that means it wont build in peoples forks unless they use
master,
{quote}
I'm not sure I quite understand what you mean here. I understand that this spec:
{code}
pull_request:
branches: [ master ]
{code}
means that it will build any PR that targets the master branch. The usual PR
flow is to create a branch against master and this spec should build that. If
you target a PR against another branch it won't - but I'm not sure that's a
problem.
It is certainly true that it won't build in a fork except on the master branch
though.
This part of the yml is also inherited from the template provided so I thought
it was likely to be a considered choice (but I guess that might be a stretch!)
I'm certainly not attached to these details of the action and if another
committer wants to do something else this is only intended to be a useful start.
> Use github actions for some simple CI
> -------------------------------------
>
> Key: PROTON-2253
> URL: https://issues.apache.org/jira/browse/PROTON-2253
> Project: Qpid Proton
> Issue Type: Improvement
> Components: build
> Reporter: Andrew Stitcher
> Assignee: Andrew Stitcher
> Priority: Major
> Fix For: proton-c-0.32.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
