jiridanek commented on a change in pull request #783:
URL: https://github.com/apache/qpid-dispatch/pull/783#discussion_r460573010
##########
File path: console/react/src/details/detailsTablePage.js
##########
@@ -42,7 +42,7 @@ import { dataMap } from "../overview/entityData";
import { dataMap as detailsDataMap, defaultData } from "./entityData";
import Updated from "../common/updated";
-class DetailTablesPage extends React.Component {
+class DetailsTablePage extends React.Component {
Review comment:
Just aligning the name with the rest of the app (I got confused by this
before, I grepped for the class name ans so it nowhere used.)
##########
File path: console/react/test_data/qdrService.mock.js
##########
@@ -60,17 +62,13 @@ export const mockService = ({ onSendMethod }) => {
resolve();
});
},
- startUpdating: () => {
- return new Promise(resolve => {
- resolve();
- });
- },
Review comment:
Fix for `63:9 warning Duplicate key 'startUpdating' no-dupe-keys`
##########
File path: console/react/src/details/detailsTablePage.js
##########
@@ -105,7 +105,7 @@ class DetailTablesPage extends React.Component {
if (!this.unmounted)
this.setState({ rows, lastUpdated: new Date() }, () => {
if (this.props.details) {
- this.props.lastUpdated(this.state.lastUpdated);
+ this.props.lastUpdated(this.state.lastUpdated);
Review comment:
```suggestion
this.props.lastUpdated(this.state.lastUpdated);
```
##########
File path: console/react/test_data/qdrService.mock.js
##########
@@ -37,19 +37,21 @@ export const mockService = ({ onSendMethod }) => {
const cbSendMethod = onSendMethod ? onSendMethod : () => {};
return {
management: {
+ schema: () => schema,
Review comment:
Fix for `TypeError: this.props.service.management.schema is not a
function`
##########
File path: console/react/src/details/detailsTablePage.test.js
##########
@@ -39,7 +39,8 @@ it("renders the DetailTablesPage", () => {
},
details: true,
service,
- schema: service.schema
+ schema: service.schema,
+ lastUpdated: (date) => {},
Review comment:
Fix for `TypeError: this.props.lastUpdated is not a function`
##########
File path: console/react/test_data/qdrService.mock.js
##########
@@ -37,19 +37,21 @@ export const mockService = ({ onSendMethod }) => {
const cbSendMethod = onSendMethod ? onSendMethod : () => {};
return {
management: {
+ schema: () => schema,
connection: {
sendMethod: () => {
cbSendMethod();
return Promise.resolve(methodResults);
},
is_connected: () => true,
- setReconnect: () => {}
+ setReconnect: () => {},
+ getReceiverAddress: () => 'mockReceiverAddress',
Review comment:
Fix for `TypeError:
this.service.management.connection.getReceiverAddress is not a function`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
