gemmellr commented on pull request #684: URL: https://github.com/apache/qpid-dispatch/pull/684#issuecomment-666255843
I think it would have been nice to squash the changes before pushing to the repo, 6 (well, I just made a 7th :P) commits for this relatively straightforward addition seems unecessary and complicates the history later for no real gain, with e.g some changes adding and removed in the same push, and the licence changes seperate from the changes that requires them. If trying to preserve authorship then just 2 would have at least been simpler. The original commits would still have remained here on the PR if they were simply being 'saved' for future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
