kgiusti commented on a change in pull request #803:
URL: https://github.com/apache/qpid-dispatch/pull/803#discussion_r463796372
##########
File path: src/router_core/connections.c
##########
@@ -1312,78 +1312,81 @@ void qdr_check_addr_CT(qdr_core_t *core, qdr_address_t
*addr)
static void qdr_connection_opened_CT(qdr_core_t *core, qdr_action_t *action,
bool discard)
{
-
qdr_connection_t *conn =
safe_deref_qdr_connection_t(action->args.connection.conn);
- if (!discard && conn) {
- do {
- DEQ_ITEM_INIT(conn);
- DEQ_INSERT_TAIL(core->open_connections, conn);
+ if (!conn)
Review comment:
Oh wait - if the conn has been freed whilst the action was queued conn
will be null but connection_label and container_id will still need to be freed,
right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
