ted-ross commented on a change in pull request #817:
URL: https://github.com/apache/qpid-dispatch/pull/817#discussion_r467223904
##########
File path: src/dispatch.c
##########
@@ -358,14 +358,14 @@ static void qd_dispatch_set_router_area(qd_dispatch_t
*qd, char *_area) {
void qd_dispatch_free(qd_dispatch_t *qd)
{
if (!qd) return;
+ qd_router_free(qd->router);
Review comment:
You've made a significant change to the shutdown order here. I think it
would be less risky to just move the qd_dispatch_set_router_* from the
beginning to the end. Those are just freeing allocated memory slots.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
