kpvdr commented on a change in pull request #256:
URL: https://github.com/apache/qpid-proton/pull/256#discussion_r469349354
##########
File path: python/proton/_message.py
##########
@@ -90,13 +90,16 @@ def _check(self, err):
def _check_property_keys(self):
for k in self.properties.keys():
- if isinstance(k, unicode):
- # py2 unicode, py3 str (via hack definition)
+ # Check for string type. (py2: unicode, py3: str via type hack
above)
+ # String subclasses symbol and char are excluded
+ # (But so are other string subclasses that would be encoded as
type string!)
+ if type(k) == unicode:
Review comment:
After discussion, we think that AMQP subclasses of string should be
excluded from the conversion. Thus, symbol and char will cause an exception,
but other user-defined subclasses will be converted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
