jiridanek commented on pull request #271: URL: https://github.com/apache/qpid-proton/pull/271#issuecomment-703830429
The `BUILD_TESTING` option is a standard CMake/CTest feature. A well-behaved project should work with it, not against it. https://cmake.org/cmake/help/v3.7/module/CTest.html By default, it is `BUILD_TESTING=ON`. The ability to turn it off is there for experienced users who have their reasons, know what they are doing, and appreciate this level of control over the build. Maven has a similar set of features. When running `mvn package`, it is possible to skip running tests, skip building tests altogether (maven doc discourages doing that, but it is possible), skip the RAT check, and skip building javadoc. I am all for keeping `BUILD_TESTING=ON` by default. But setting it to OFF should actually work, that is, stop building the tests. Currently, the project alwaysbuilds and runs the tests, irrespective of this setting. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
