alex-rufous commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500679615
##########
File path:
broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3521,46 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ executeTransactionAndLogResults("copyMessages", destination.getName(),
transaction);
return transaction.getModifiedMessageIds();
}
+ private void executeTransactionAndLogResults(final String msg,
Review comment:
The parameter name 'msg' needs to be changed to operationName
Let's move transaction parameter to a second position
the destinationName can be renamed into a targetDestinationName
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
