grs commented on a change in pull request #888:
URL: https://github.com/apache/qpid-dispatch/pull/888#discussion_r510337023
##########
File path: src/adaptors/http1/http1_client.c
##########
@@ -722,6 +724,17 @@ static int
_client_rx_headers_done_cb(h1_codec_request_state_t *hrs, bool has_bo
qd_compose_insert_string(props, hconn->cfg.address); // to
qd_compose_insert_string(props, h1_codec_request_state_method(hrs)); //
subject
qd_compose_insert_string(props, hconn->client.reply_to_addr); // reply-to
+ qd_compose_insert_null(props); // correlation-id
+ qd_compose_insert_null(props); // content-type
+ qd_compose_insert_null(props); // content-encoding
+ qd_compose_insert_null(props); // absolute-expiry-time
+ qd_compose_insert_null(props); // creation-time
+ qd_compose_insert_string(props, hconn->cfg.site); // group-id
+
+ assert(hconn->client.reply_to_addr &&
strlen(hconn->client.reply_to_addr)); //remove me
Review comment:
Not the assert! I must have accidentally included that when merging
conflicts in the rebase. Will remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
