[
https://issues.apache.org/jira/browse/DISPATCH-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221537#comment-17221537
]
ASF GitHub Bot commented on DISPATCH-1815:
------------------------------------------
ganeshmurthy commented on a change in pull request #897:
URL: https://github.com/apache/qpid-dispatch/pull/897#discussion_r512825599
##########
File path: src/adaptors/http2/http2_adaptor.h
##########
@@ -138,6 +141,7 @@ struct qdr_http2_connection_t {
bool ingress;
bool timer_scheduled;
bool client_magic_sent;
+ time_t prev_ping; // Time the previous PING frame was
sent on egress connection.
Review comment:
The check_send_ping_frame() only conditionally updates the
conn->prev_ping field like this -
time_t current = time(NULL);
time_t prev = conn->prev_ping;
if (current - prev >= 4) {
send_ping_frame(conn);
qd_log(http2_adaptor->log_source, QD_LOG_TRACE, "[C%"PRIu64"] Sent
PING frame", conn->conn_id);
qd_timer_schedule(conn->ping_timer, 4000);
conn->prev_ping = current;
}
So the conn->prev_ping contains the time that the ping was sent out ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Send PING frames to keep the router-http2 server connection alive
> -----------------------------------------------------------------
>
> Key: DISPATCH-1815
> URL: https://issues.apache.org/jira/browse/DISPATCH-1815
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Protocol Adaptors
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.15.0
>
>
> When the router makes a connection to the http2 server, that connection is
> disconnected by the server if the connection remains idle for more than 5
> seconds. Send a PING on that connection every 4 seconds to keep that
> connection alive.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
