[
https://issues.apache.org/jira/browse/DISPATCH-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221562#comment-17221562
]
ASF GitHub Bot commented on DISPATCH-1815:
------------------------------------------
grs commented on a change in pull request #897:
URL: https://github.com/apache/qpid-dispatch/pull/897#discussion_r512855336
##########
File path: src/adaptors/http2/http2_adaptor.h
##########
@@ -138,6 +141,7 @@ struct qdr_http2_connection_t {
bool ingress;
bool timer_scheduled;
bool client_magic_sent;
+ time_t prev_ping; // Time the previous PING frame was
sent on egress connection.
Review comment:
Right, and that is fine. All I'm saying is that if you send out any
other frame within the second, there is no need to send a ping. However that is
an optimisation. It is good as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Send PING frames to keep the router-http2 server connection alive
> -----------------------------------------------------------------
>
> Key: DISPATCH-1815
> URL: https://issues.apache.org/jira/browse/DISPATCH-1815
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Protocol Adaptors
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.15.0
>
>
> When the router makes a connection to the http2 server, that connection is
> disconnected by the server if the connection remains idle for more than 5
> seconds. Send a PING on that connection every 4 seconds to keep that
> connection alive.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
