kgiusti commented on a change in pull request #936:
URL: https://github.com/apache/qpid-dispatch/pull/936#discussion_r538637008
##########
File path: src/adaptors/http2/http2_adaptor.c
##########
@@ -393,6 +395,10 @@ static qdr_http2_stream_data_t
*create_http2_stream_data(qdr_http2_session_data_
qd_message_set_stream_annotation(stream_data->message, true);
stream_data->session_data = session_data;
stream_data->app_properties =
qd_compose(QD_PERFORMATIVE_APPLICATION_PROPERTIES, 0);
+ if (!stream_data->app_properties) {
+ qd_compose_free(stream_data->app_properties);
Review comment:
wait, what? check for null, free null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
