jiridanek commented on a change in pull request #943:
URL: https://github.com/apache/qpid-dispatch/pull/943#discussion_r541930776
##########
File path: src/adaptors/http2/http2_adaptor.c
##########
@@ -2242,7 +2243,8 @@ static void handle_connection_event(pn_event_t *e,
qd_server_t *qd_server, void
send_settings_frame(conn);
qd_log(log, QD_LOG_INFO, "[C%"PRIu64"] Accepted Ingress
((PN_RAW_CONNECTION_CONNECTED)) from %s", conn->conn_id, conn->remote_address);
} else {
- nghttp2_session_client_new(&conn->session_data->session,
(nghttp2_session_callbacks*)http2_adaptor->callbacks, (void *)conn);
+ if (!conn->session_data->session)
+ nghttp2_session_client_new(&conn->session_data->session,
(nghttp2_session_callbacks*)http2_adaptor->callbacks, (void *)conn);
Review comment:
style: either there should be space before * in both casts, or there
shouldn't be
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
