ted-ross commented on a change in pull request #965:
URL: https://github.com/apache/qpid-dispatch/pull/965#discussion_r546747778
##########
File path: include/qpid/dispatch/ctools.h
##########
@@ -236,7 +236,6 @@ static inline void *qd_malloc(size_t size)
static inline void *qd_calloc(size_t nmemb, size_t size)
{
- assert(nmemb && size);
void *ptr = calloc(nmemb, size);
if (!ptr) {
Review comment:
The null-pointer check is not valid in this case. The man page for
calloc states that the returned value may or may not be 0 when one of the input
arguments is 0. I strongly suspect that it is non-zero in this case for
Fedora. I would be inclined to leave the assertion in place, since we
shouldn't be calling qd_calloc with either a zero nmemb or a zero size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
