jiridanek commented on a change in pull request #966:
URL: https://github.com/apache/qpid-dispatch/pull/966#discussion_r548030509
##########
File path: tests/system_tests_bad_configuration.py
##########
@@ -112,11 +113,11 @@ def wait_for_unresolvable_host(self):
with open('../setUpClass/test-router.log', 'r') as router_log:
log_lines = router_log.read().split("\n")
expected_errors = [
- "proton:io Name or service not known", # Linux
- "proton:io unknown node or service", # macOS
+ "Connection to %s" % self.unresolvable_host_name
]
errors_caught = [line for line in log_lines
- if any([expected_error in line for expected_error
in expected_errors])]
+ if any([expected_error in line for expected_error
in expected_errors])
+ and "failed" in line]
self.error_caught = any(errors_caught)
Review comment:
Yeah, thats what I meant. If dispatch (due to a bug) stopped retrying
the connection, the test would still pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
