kgiusti commented on a change in pull request #988:
URL: https://github.com/apache/qpid-dispatch/pull/988#discussion_r559802524



##########
File path: src/router_core/error.c
##########
@@ -39,15 +46,9 @@ qdr_error_t *qdr_error_from_pn(pn_condition_t *pn)
     const char *name = pn_condition_get_name(pn);
     const char *desc = pn_condition_get_description(pn);
     pn_data_t *info = pn_condition_info(pn);
-    bool is_byt_size_gt_zero = false;

Review comment:
       Turns out, this doesn't work - testing revealed info was never getting 
set! 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to