astitcher commented on a change in pull request #989:
URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560401706
##########
File path: tools/qdstat.in
##########
@@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE
def get(obj, attr):
return getattr(obj, attr, None)
-class BusManager(Node):
+class BusManager():
Review comment:
@jiridanek Thanks for the pointers! I was wrong about new style classes.
I did a quick grep and there are a bunch of old style classes in this code
base. For leaf classes (actually such as this one) I'm not sure it's that
important as the differences seem to mostly be about metaclass and inheritance
features.
I'll change this PR before I merge it though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
