[
https://issues.apache.org/jira/browse/DISPATCH-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269074#comment-17269074
]
ASF GitHub Bot commented on DISPATCH-1750:
------------------------------------------
codecov-io commented on pull request #992:
URL: https://github.com/apache/qpid-dispatch/pull/992#issuecomment-764427921
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=h1)
Report
> Merging
[#992](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=desc)
(5ffc398) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/86226ccf06bca50e6652f9cbaa171601c74abdab?el=desc)
(86226cc) will **increase** coverage by `0.09%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #992 +/- ##
==========================================
+ Coverage 78.94% 79.04% +0.09%
==========================================
Files 111 111
Lines 28503 28502 -1
==========================================
+ Hits 22502 22528 +26
+ Misses 6001 5974 -27
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[include/qpid/dispatch/buffer.h](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-aW5jbHVkZS9xcGlkL2Rpc3BhdGNoL2J1ZmZlci5o)
| `100.00% <ø> (ø)` | |
|
[src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=)
| `3.09% <ø> (+<0.01%)` | :arrow_up: |
|
[src/buffer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL2J1ZmZlci5j)
| `100.00% <ø> (ø)` | |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `89.35% <0.00%> (-0.08%)` | :arrow_down: |
|
[src/router\_core/delivery.h](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5Lmg=)
| `100.00% <ø> (ø)` | |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `93.62% <100.00%> (+0.19%)` | :arrow_up: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.95% <100.00%> (ø)` | |
|
[src/adaptors/http1/http1\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2FkYXB0b3IuYw==)
| `82.39% <0.00%> (-0.67%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `86.84% <0.00%> (-0.22%)` | :arrow_down: |
| ... and [6
more](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=footer).
Last update
[ec39e5e...5ffc398](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update PatternFly packages for the 1.15.0 release
> -------------------------------------------------
>
> Key: DISPATCH-1750
> URL: https://issues.apache.org/jira/browse/DISPATCH-1750
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Console
> Affects Versions: 1.13.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: 1.15.0
>
> Attachments: image-2020-08-15-21-41-41-215.png,
> image-2020-08-15-21-42-00-233.png, image-2020-08-15-21-42-06-568.png,
> image-2020-09-01-12-06-13-424.png, image-2020-09-01-12-06-53-667.png
>
>
> Looking at the release notes, there don't seem to be any significant large
> changes, except for some aria accessibility improvements and minor bugfixes
> in PatternFly. I noticed a deprecation of a toolbar component used in
> Dispatch.
>
> There is only one large problem with the update, and that is package
> {{@patternfly/react-topology}}, which in it's latest version forces {{d3}}
> upgrade to version {{5.x}}, and there are significant API changes going from
> currently used version 3.x to 4.x (and smaller ones from 4.x to 5.x).
>
> When the other patternfly packages (excluding react-topology) are updated,
> the updated console works ok, just with few visual layout glitches shown
> below, which will need to be fixed before the update is committed.
>
> !image-2020-08-15-21-41-41-215.png!
>
> !image-2020-08-15-21-42-00-233.png!
>
> !image-2020-08-15-21-42-06-568.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
