pjfawcett commented on a change in pull request #278:
URL: https://github.com/apache/qpid-proton/pull/278#discussion_r563162126
##########
File path: cpp/src/connection.cpp
##########
@@ -192,6 +193,13 @@ std::vector<symbol> connection::desired_capabilities()
const {
return get_multiple<std::vector<symbol> >(caps);
}
+std::map<symbol, value> connection::properties() const {
+ map<symbol, value> props(pn_connection_remote_properties(pn_object()));
+ std::map<symbol, value> props_ret;
+ get(props, props_ret);
+ return props_ret;
Review comment:
Thank you for your comments. I agree my code is wasteful in the case
where there are no properties and I will rectify that. However, I think it was
necessary to create an intermediate `proton::map` in order to get the `decoder`
to process all the properties data, rather than just the first key - buy I may
be mis-remembering things so will have another go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
