astitcher commented on a change in pull request #291:
URL: https://github.com/apache/qpid-proton/pull/291#discussion_r563860281
##########
File path: cpp/examples/ssl.cpp
##########
@@ -165,16 +165,19 @@ int main(int argc, char **argv) {
opts.parse();
size_t sz = cert_directory.size();
- if (sz && cert_directory[sz -1] != '/')
- cert_directory.append("/");
- else cert_directory = "ssl-certs/";
+ if (sz) {
+ if (cert_directory[sz -1] != '/')
+ cert_directory.append("/");
+ } else cert_directory = "ssl-certs/";
Review comment:
Bad indentation (yes I know the original was bad too!) please use
explicit '{' and '}' and indent. I'd also prefer the else to be indented in a
'{' '}' block too, but that's not bad indentation (IMO).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
