jiridanek commented on a change in pull request #1013:
URL: https://github.com/apache/qpid-dispatch/pull/1013#discussion_r568804795
##########
File path: python/qpid_dispatch_internal/management/qdrouter.py
##########
@@ -40,7 +40,7 @@ class QdSchema(schema.Schema):
def __init__(self):
"""Load schema."""
- qd_schema = get_data('qpid_dispatch.management', 'qdrouter.json')
+ qd_schema = get_data('qpid_dispatch.management',
'qdrouter.json').decode('utf8')
Review comment:
This is always supposed to produce `bytes`. Weird that it ever worked on
Python 3. https://docs.python.org/3/library/pkgutil.html#pkgutil.get_data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
