ted-ross commented on a change in pull request #1018:
URL: https://github.com/apache/qpid-dispatch/pull/1018#discussion_r570513708
##########
File path: src/router_core/transfer.c
##########
@@ -219,14 +217,32 @@ int qdr_link_process_deliveries(qdr_core_t *core,
qdr_link_t *link, int credit)
dlv->where = QDR_DELIVERY_IN_UNSETTLED;
qd_log(core->log, QD_LOG_DEBUG, DLV_FMT"Delivery
transfer: qdr_link_process_deliveries: undelivered-list -> unsettled-list",
DLV_ARGS(dlv));
}
+ } else {
+ //
+ // This delivery is in the process of being transfered
+ // to a different link. Hack: the adaptor
+ // deliver_handler has issued a new link-attached
+ // action to the core, passing this dlv as the initial
Review comment:
I don't think that's needed. The MOVED_TO_NEW_LINK tells the core that
the delivery has been referenced for use as the initial delivery on a different
link. The core (qdr_process_deliveries) should use this information to remove
the delivery (complete or not) from the undelivered list because it is safely
referenced elsewhere. Just keep in mind that the delivery's new link may have
already move it by the time MOVED_TO_NEW_LINK is seen.
There are two places where the removal from undelivered can happen: in
qdr_process_deliveries when MOVED_TO_NEW_LINK is returned, and in
first_attach_CT when the delivery is supplied to a new link. Exactly one of
these must perform the switcheroo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
