jiridanek commented on a change in pull request #297:
URL: https://github.com/apache/qpid-proton/pull/297#discussion_r578619627
##########
File path: CMakeLists.txt
##########
@@ -132,6 +132,38 @@ if (CMAKE_BUILD_TYPE MATCHES "Coverage")
COMMAND ${CMAKE_SOURCE_DIR}/scripts/record-coverage.sh ${CMAKE_SOURCE_DIR}
${CMAKE_BINARY_DIR})
endif()
+# Enable asserts for C/C++ code if requested
+# from the LLVM project,
https://opensource.apple.com/source/llvmCore/llvmCore-2358.3/CMakeLists.txt.auto.html
+if(CMAKE_BUILD_TYPE STREQUAL "Debug" )
+ option(PN_ENABLE_ASSERTIONS "Enable assertions" ON)
+else()
+ option(PN_ENABLE_ASSERTIONS "Enable assertions" OFF)
+endif()
+if(PN_ENABLE_ASSERTIONS)
Review comment:
Ack, will rename.
It has the same justification as the `pn_` prefix in the C library. Somebody
might include this CMake build in their own project (as a subproject: CMake
supports fetching subprojects over HTTP, Git, ....) and then there would be
value in being able to configure options for each project separately. I admit
that here is a poor place where to start introducing the convention. Especially
since I dont intend to apply it uniformly everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
