jiridanek commented on a change in pull request #1080:
URL: https://github.com/apache/qpid-dispatch/pull/1080#discussion_r598504299
##########
File path: src/server.c
##########
@@ -1372,6 +1372,10 @@ qd_server_t *qd_server(qd_dispatch_t *qd, int
thread_count, const char *containe
void qd_server_free(qd_server_t *qd_server)
{
if (!qd_server) return;
+
+ qd_http_server_stop(qd_server->http); /* Stop HTTP threads immediately */
+ qd_http_server_free(qd_server->http);
Review comment:
It appears that calling only `qd_http_server_free` is indeed sufficient.
I was thinking that maybe calling _stop before _free is some sort of dispatch
convention... Do you want me to remove the call to _stop here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
