jiridanek commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r617712959
##########
File path: cpp/src/sender.cpp
##########
@@ -66,8 +66,15 @@ uint64_t tag_counter = 0;
tracker sender::send(const message &message) {
uint64_t id = ++tag_counter;
- pn_delivery_t *dlv =
- pn_delivery(pn_object(), pn_dtag(reinterpret_cast<const char*>(&id),
sizeof(id)));
+ const binary tag(
+ std::string(reinterpret_cast<const char *>(&id), sizeof(id)));
Review comment:
I don't much like bringing in `std::string`. What about this?
```
const uint8_t *begin = reinterpret_cast<const uint8_t *>(&id);
const binary tag(begin, begin + sizeof(id));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
