jiridanek commented on a change in pull request #1153:
URL: https://github.com/apache/qpid-dispatch/pull/1153#discussion_r618452376



##########
File path: .travis.yml
##########
@@ -204,7 +212,7 @@ script:
 - popd
 # Workaround on macOS for PROTON-808 Binaries have their library locations 
stripped
 - if [[ "${OSTYPE}" == "darwin"* ]]; then install_name_tool -add_rpath 
$PREFIX/lib/. $PREFIX/lib/proton/bindings/python/_cproton.so; fi
-- ctest -V ${DISPATCH_CTEST_EXTRA} && if [ "$BUILD_TYPE" = "Coverage" ]; then 
cmake --build . --target coverage; fi
+- ctest --timeout 1200 -V ${DISPATCH_CTEST_EXTRA} && if [ "$BUILD_TYPE" = 
"Coverage" ]; then cmake --build . --target coverage; fi

Review comment:
       Let's not forget that there is a Travis timeout which kills a build if 
it has not produced any output for 10 minutes. With a big timeout like this, 
what can happen is that if a test gets stuck, the first thing that triggers is 
the Travis timeout and that kills the entire CI job.
   
   Solution would be to play with timeouts more, or run a background process 
that is printing dots every 5 minutes or so... Lets see if we actually hit this 
problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to