jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-835778691
I tried writing a test for shutdown crash with connected websocket in both Python unittest and C++ doctest. The Python unittest runs cca 600 ms start to finish, the C++ doctest about 400 ms. I did not investigate deeper, but I guess this is due to extra instance of Python being started (to run the tests) and due to the facts the system-tests framework does extra work that involves I/O (trying for open socket, checking if router started up, ...) There is very little that running things in-process can improve on what the Python tests do here. The little things will likely add up, but not enough to e.g. warrant rewriting tests from unittest to doctest. The wins have to be found elsewhere: * ability to avoid bringing up and shutting down python and alloc pool repeatedly; is it possible to run realistic scenarios while keeping python around? Possibly doing some checks to ensure there are not undesirable Python objects surviving from one test to the next one. It would need experimentation to see if this is doable and actual measurements to see if this is worth it. Alloc pool is actually very fast to start up. ** given that the test crashes in ci on segv in `lws_get_vhost_port`, means I don't properly wait for the listener to go up; so maybe the c++ doctest will run somewhat slower when I add the proper check/wait (not sure how to do this yet) * write integration tests in doctest, instead of testing things end-to-end (leave that for the system-tests). Is it possible to do useful testing involving multiple components without starting the entire router? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
