kgiusti commented on a change in pull request #1207:
URL: https://github.com/apache/qpid-dispatch/pull/1207#discussion_r631825675
##########
File path: tools/qdstat.in
##########
@@ -540,8 +540,12 @@ class BusManager(object):
row.append(PlainNum(node.routerLink))
if self.opts.verbose:
- row.append(get(node, 'protocolVersion'))
- row.append(get(node, 'cost'))
+ row.append(PlainNum(get(node, 'protocolVersion')))
+ cost = get(node, 'cost')
+ if cost:
Review comment:
But that isn't clear from the code on line 548: to me I read
548: row.append(cost)
And I think it's going to output either "0" or "None".
Change line 548 to:
row.append("")
to make it obvious that the output is to be blank.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
