jiridanek commented on a change in pull request #1221:
URL: https://github.com/apache/qpid-dispatch/pull/1221#discussion_r634199477
##########
File path: tests/http1_tests.py
##########
@@ -272,13 +273,11 @@ def http1_ping(sport, cport):
]
}
- server = TestServer(server_port=sport,
- client_port=cport,
- tests=TEST)
+ server = wait_server_starting(sport, cport, TEST)
Review comment:
This problem would go away entirely if the test could start the server
first, before routers, with `TestServer(server_port=0, ...` and then queried
the server for an actual port when starting the routers. But if the approach of
the PR works reliably, then I see no reason to do yet another change to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
