jiridanek commented on a change in pull request #315:
URL: https://github.com/apache/qpid-proton/pull/315#discussion_r639133888
##########
File path: c/tests/pn_test.hpp
##########
@@ -129,7 +130,7 @@ struct handler {
struct driver : public ::pn_connection_driver_t {
struct handler &handler;
- driver(struct handler &h);
+ explicit driver(struct handler &h);
Review comment:
I got it from clang-tidy and
https://google.github.io/styleguide/cppguide.html#Implicit_Conversions. The
widely accepted rule seems to put `explicit` everywhere, unless there is a very
good reason not to. (And I can do this freely here, because I am not touching
public API.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
