ChugR commented on a change in pull request #1254:
URL: https://github.com/apache/qpid-dispatch/pull/1254#discussion_r648670924



##########
File path: src/adaptors/tcp_adaptor.c
##########
@@ -677,6 +678,19 @@ static void 
qdr_tcp_connection_ingress_accept(qdr_tcp_connection_t* tc)
     allocate_tcp_buffer(&tc->read_buffer);
     tc->remote_address = get_address_string(tc->pn_raw_conn);
     tc->global_id = get_global_id(tc->config.site_id, tc->remote_address);
+
+    // Create the tcp connection properties map.
+    pn_data_t *props = pn_data(0);

Review comment:
       Ok. Eventually consoles and such will want to differentiate between 
infrastructure connections (egress_dispatch) and user connections that consume 
router resources by sending/receiving traffic. Making them all the same is good 
enough for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to