astitcher commented on a change in pull request #1268:
URL: https://github.com/apache/qpid-dispatch/pull/1268#discussion_r655449905
##########
File path: python/qpid_dispatch_internal/tools/command.py
##########
@@ -261,9 +261,8 @@ def opts_url(opts):
url = Url(opts.bus)
# If the options indicate SSL, make sure we use the amqps scheme.
- if opts.ssl_certificate or opts.ssl_trustfile:
+ if opts.ssl_certificate or opts.ssl_trustfile or
opts.bus.startswith("amqps"):
Review comment:
This looks wrong shouldn't it be ...startswith("amqps:")? Otherwise what
happens if you connect to amqps.com?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
